Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] $body-font-family as an assignable variable #371

Closed
xelaint opened this issue Aug 9, 2019 · 2 comments
Closed

[FEAT] $body-font-family as an assignable variable #371

xelaint opened this issue Aug 9, 2019 · 2 comments
Assignees
@damienwebdev
Labels
feat a new feature, enhancement, or improvement hacktoberfest This PR or issue is related to Hacktoberfest package: design @daffodil/design
Projects
The Design Library
Milestone
v0.8.0 - The Desi...

Comments

@xelaint
Copy link
Member

xelaint commented Aug 9, 2019 •
edited
Loading

馃挕 Feature request

Feature Name

Allow $body-font-family to be an assignable variable

The Desired Behavior

$body-font-family should be assignable so that when @daffodil/design is used, users can assign their brand font to $body-font-family.

https://thoughtbot.com/blog/sass-default

Your Use Case

As a user, I should be able to specify my own $body-font-family.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:
@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Aug 9, 2019
@xelaint xelaint added this to the v0.8.0 - The Design Package V2 milestone Aug 9, 2019
@xelaint xelaint added this to To do in The Design Library via automation Aug 9, 2019
@xelaint xelaint changed the title [FEAT] Allow body font to be an assignable variable [FEAT] $body-font-family as an assignable variable Sep 3, 2019
@xelaint xelaint added the hacktoberfest This PR or issue is related to Hacktoberfest label Oct 9, 2020
@damienwebdev
Copy link
Member

This should probably be brought into a Design Token. #1880

@xelaint
Copy link
Member Author

xelaint commented Jan 6, 2022

@damienwebdev Closing this issue. Merged this with #1880

@xelaint xelaint closed this as completed Jan 6, 2022
The Design Library automation moved this from To do to Done Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienwebdev damienwebdev

Labels
feat a new feature, enhancement, or improvement hacktoberfest This PR or issue is related to Hacktoberfest package: design @daffodil/design
Projects
The Design Library
Status: Done
The Design Library
  
Done
Milestone
v0.8.0 - The Design Package V2
Development

No branches or pull requests
2 participants
@damienwebdev @xelaint