Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement expand #8

Closed
GrayJack opened this issue Sep 27, 2019 · 8 comments
Closed

Implement expand #8

GrayJack opened this issue Sep 27, 2019 · 8 comments
Assignees
Labels
A-tool Area: Binary tool C-tracking-issue Category: A tracking issue for an feature. good first issue Good for newcomers Hacktoberfest Hacktoberfest
Projects

Comments

@GrayJack
Copy link
Owner

No description provided.

@GrayJack GrayJack created this issue from a note in Roadmap (To do) Sep 27, 2019
@GrayJack GrayJack added good first issue Good for newcomers Hacktoberfest Hacktoberfest labels Sep 27, 2019
@muskuloes
Copy link

Hi @GrayJack , Can I work on this?

@GrayJack
Copy link
Owner Author

GrayJack commented Oct 4, 2019

Yes, of course 😄

@GrayJack GrayJack moved this from To do to In progress in Roadmap Oct 4, 2019
@muskuloes
Copy link

Hi, sorry for the inactivity on this issue. I haven't had the time to work on it yet. Also, I've seen that unexpand has already been implemented. So, if @bojan88 (whom I know from another project) wouldn't mind, he can implement this one as well :) .

@bojan88
Copy link
Contributor

bojan88 commented Oct 25, 2019

Please, feel free to implement it. Of course I don't mind.
I might join for code reviews

@muskuloes
Copy link

It's best that you do expand as it'll be very similar to unexpand and you already own the code for that. I won't like to have my name on it, if I just mostly copied your code. I'll find some other issue to work on some other time 😉.

@GrayJack
Copy link
Owner Author

GrayJack commented Oct 25, 2019

In that case, if most of the code is copied, is just a matter to put his name (with yours too) on the crate and author text 😄

As long there is a proper attribution, I really don't care who made the PR

@bojan88
Copy link
Contributor

bojan88 commented Oct 27, 2019

I also don't mind if you copy most of my code.

@muskuloes
Copy link

Alright guys. I'll do it in the week. @bojan88, I'll add your name as author and will appreciate you reviewing the PR 😅.

@muskuloes muskuloes mentioned this issue Nov 2, 2019
Roadmap automation moved this from In progress to Done Nov 3, 2019
@GrayJack GrayJack added C-tracking-issue Category: A tracking issue for an feature. A-tool Area: Binary tool labels Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tool Area: Binary tool C-tracking-issue Category: A tracking issue for an feature. good first issue Good for newcomers Hacktoberfest Hacktoberfest
Projects
Roadmap
  
Done
Development

No branches or pull requests

3 participants