remove autograd.Variable and fixed symbol P #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SpellOnYou Thanks for Contribution, but Why don't you recommit your github nickname to stay? |
|
@SpellOnYou There is some wrong thing. 'P' is abbreviation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable API has been deprecated. you can remove this. I just provided an example with basic attention model. if you agree with me, retune it.
https://pytorch.org/docs/stable/autograd.html#variable-deprecated
sequence to sequence model has n_step variable(i guess you mean padding... right? but I just little confused that you used identical terminology even if this is tutorial.