New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment errors in NNLM #63

Merged

graykode merged 1 commit into graykode:master from secsilm:master

May 2, 2021

Contributor

secsilm commented Oct 20, 2020

Small mistakes in NNLM:

X = self.C(X) # X : [batch_size, n_step, n_class]
X = X.view(-1, n_step * m) # [batch_size, n_step * n_class]

should be

X = self.C(X) # X : [batch_size, n_step, m]
X = X.view(-1, n_step * m) # [batch_size, n_step * m]


          Fix comment errors in NNLM.py

af0b28a

ZonePG commented Jan 24, 2021

@secsilm you are right, I think so too

graykode merged commit 8ec1aeb into graykode:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment