Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: change restart: 'always' #5

Closed
bmaupin opened this issue Sep 27, 2021 · 1 comment
Closed

Feature request: change restart: 'always' #5

bmaupin opened this issue Sep 27, 2021 · 1 comment
Labels

Comments

@bmaupin
Copy link

bmaupin commented Sep 27, 2021

I needed to spin up a Graylog server quickly for testing, and I was very happy to find this repo.

It works quite well, but I was quite surprised to find that it started itself back up again when I rebooted my computer. I checked the README, expecting to see that this repo was meant for running production instances of Graylog, but instead I saw:

This is a set of Docker Compose files that allow you to quickly spin up a Graylog instance for testing or demo purposes.

If the purpose of this project is "for testing or demo purposes," restart: 'always' seems a bit aggressive.

I could see a restart policy of on-failure being useful to avoid embarrassment if it crashed during a demo, or save some work if it crashed during testing.

If it would save you some time I'd be happy to make a PR.

Thanks!

@bernd bernd added the triaged label Sep 27, 2021
@malcyon
Copy link
Contributor

malcyon commented Oct 19, 2021

You know, it didn't occur to me that is why it was doing that. Thanks for pointing that out. I'll get it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants