Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instances of node.set with node.default/node.normal #80

Closed
webframp opened this issue Nov 18, 2016 · 0 comments
Closed

Replace instances of node.set with node.default/node.normal #80

webframp opened this issue Nov 18, 2016 · 0 comments

Comments

@webframp
Copy link
Contributor

This is a future deprecation warning currently.

In line with the recommendation here: https://docs.chef.io/ruby.html#node-set it is better to use node.default in most cases as this is rebuilt on the node object during each chef run. Where persistence is really needed, node.normal is more clear.
webframp added a commit to webframp/graylog2-cookbook that referenced this issue Nov 22, 2016
@webframp
Replace node.set with node.default in server recipe
066b6a2 
The primary difference being that node.set is persisted with the node object,
whereas node.default is built during each chef run. Since this usage is using
`search_for_nodes` to discover the value during the chef run node.default seems
like it should be safe.

This is in line with current community recommendations and partially fixes Graylog2#80
webframp added a commit to webframp/graylog2-cookbook that referenced this issue Nov 22, 2016
@webframp
Replace node.set with node.normal in specs
ed4e9ba 
Not clear if the persistence is really needed in the specs, but this preserves
the current behavior and removes the warnings.

fixes Graylog2#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@webframp