Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local implementation is not atomic, isolated, durable #219

Open
urisimchoni opened this issue Sep 15, 2019 · 0 comments · May be fixed by #220
Open

Local implementation is not atomic, isolated, durable #219

urisimchoni opened this issue Sep 15, 2019 · 0 comments · May be fixed by #220

Comments

@urisimchoni
Copy link
Contributor

The general expectation from a blob store is that PUT operations for single files are atomic, isolated, and durable:

  • either the whole PUT succeeds or the file keeps its old content
  • none sees the effect of the PUT until it's complete
  • a successful put means the data is stored in some non-volatile way

The current Local adapter doesn't fulfill any of those because it truncates the file at the beginning of the PUT if it already exists, and because it doesn't call Sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant