-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VFD as default spindle ($395) does not expose VFD settings #21
Comments
Are you compiling with the Web Builder? |
I am compiling from source (plugins plus UF2 bootloader packaging). I am using VFD_ENABLE of -1 and N_SPINDLE of 8 so that support for all the different VFDs is compiled in and the user can change at runtime. |
Oops, I am messing up a bit, too much going on... Try with this spindle/select.c: I'll be away for a few days so do not have time for much testing. |
This seems to have resolved the issue. Thanks for the quick fix, I figured it was something simple and I just wasn't seeing it. |
The dynamic spindle selection seems to work well for VFD spindles when they are selected as spindle > 0. The is_vfd_spindle and _is_modvfd_selected functions expose the appropriate settings and they appear to work as expected.
But if I set the default spindle to be one of the VFD spindles, it never enumerates correctly. $476 is never exposed, nor do the MODVFD settings if that spindle is selected. It does appear that the MODVFD spindle is in fact being activated by the core as I can see traffic on the RS485 interface and it generates error14 when it can't communicate. I have spent a fair amount of time trying to figure out where it is going wrong but no success yet.
The text was updated successfully, but these errors were encountered: