Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of InstrumentResponse from threeML is incorrect #12

Closed
dsvinkin opened this issue Mar 11, 2020 · 2 comments
Closed

Import of InstrumentResponse from threeML is incorrect #12

dsvinkin opened this issue Mar 11, 2020 · 2 comments

Comments

@dsvinkin
Copy link

Hi all!
The import statement in drmgen.py
from threeML.utils.response import InstrumentResponse
should be
from threeML.utils.OGIP.response import InstrumentResponse
to correspond of the current structure of threeML.

@grburgess
Copy link
Owner

thanks! If you would, could you make fork and do a PR? I've also separated the the response stuff out of 3ML to bypass that as a dependency, but this should be fixed.

@grburgess
Copy link
Owner

Thanks for fixing this @dsvinkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants