Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline shader props #10

Closed
gre opened this issue Sep 7, 2015 · 0 comments
Closed

Support for inline shader props #10

gre opened this issue Sep 7, 2015 · 0 comments

Comments

@gre
Copy link
Owner

gre commented Sep 7, 2015

<GL.View
  shader={{ frag: "..." }}
  ... />

Use-case: shader editor

To do this, we need to introduce .remove(id) on GL.Shaders and implement it in implementations.

gl-react might do most of the work by handling the create / remove and providing shader id to the Surface implementations. remove is called when a previous inline shader is gone and when the Surface is destroyed (we somehow need to hook on this from gl-react side).

@gre gre added the feature label Sep 7, 2015
@gre gre added this to the 2.0.0 milestone Oct 10, 2015
@gre gre removed this from the 2.0.0 milestone Oct 23, 2015
@gre gre added this to the 2.1.0 milestone Dec 30, 2015
@gre gre closed this as completed in be7bb3c Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant