Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize performance of the gl-react-core search algorithm #15

Closed
gre opened this issue Sep 21, 2015 · 0 comments
Closed

optimize performance of the gl-react-core search algorithm #15

gre opened this issue Sep 21, 2015 · 0 comments
Labels
perf priority:medium
Milestone
1.1.0

Comments

@gre
Copy link
Owner

gre commented Sep 21, 2015

childVDOMs() might be a current bottleneck (in the JS/React part, very negligible when comparing with the GL part which is much more intensive)

a simple way to optimize this is to compute the "children vdoms" once for each data node, and just make this an accessor.
because currently, as we going down the tree, we are recomputing again everything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
perf priority:medium
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@gre