Invalid Temp Table SQL for MSSQL

[rlshuhart]

There looks to be similar open issue (#1012), but opening this for the specific invalid syntax for temp tables with mssql.

When following great_expectations init and using a relational database option with MSSQL connection, the following error occurs:

 "[42000] [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Unknown object type 'TEMPORARY' used in a CREATE, DROP, or ALTER statement. (343) (SQLExecDirectW)")

I'll see if I can suggest a PR to fix this.

[kepiej]

I encountered the same problem. I think it can be fixed by adding another elif clause to create_temporary_table() in sqlalchemy_dataset.py as follows:

elif self.engine.dialect.name == "mssql":
     custom_sqlmod = custom_sql.split('from')
     stmt = (custom_sqlmod[0] + "into #{table_name} from" + custom_sqlmod[1]).format(table_name=table_name)

Temporary tables in MSSQL are indicated by #.

[rlshuhart]

I've been buried. Thanks @kepiej!