Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"$" character in user's response to a CLI prompt is mistakenly interpreted as a variable to substitute #1927

Closed
eugmandel opened this issue Sep 25, 2020 · 1 comment · Fixed by #1949
Closed

"$" character in user's response to a CLI prompt is mistakenly interpreted as a variable to substitute #1927

eugmandel opened this issue Sep 25, 2020 · 1 comment · Fixed by #1949
Assignees
@anthonyburdi
Labels
blocker bug A bug that blocks a user from completing a use case bug Bugs bugs bugs! core-team-priority

Comments

@eugmandel
Copy link
Contributor

Describe the bug
"$" character in user's response to a CLI prompt is mistakenly interpreted as a variable to substitute

image

To Reproduce
Steps to reproduce the behavior:

  1. Add a Datasource in the CLI
  2. Choose a database, answer one of the prompts (e.g., password) with a string that contains the "$" character
  3. See the error

Expected behavior
The "$" character should not be treated specially in user's answer to prompts

Environment (please complete the following information):

  • OS: N/A
  • GE Version: 0.12.1

Additional context
N/A
@eugmandel eugmandel added bug Bugs bugs bugs! triage Used by the GE core team to flag issues that were not yet triaged blocker bug A bug that blocks a user from completing a use case core-team-priority and removed triage Used by the GE core team to flag issues that were not yet triaged labels Sep 25, 2020
@eugmandel
Copy link
Contributor Author

This issue went through triage - the core team will develop a fix.

@anthonyburdi anthonyburdi mentioned this issue Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonyburdi anthonyburdi

Labels
blocker bug A bug that blocks a user from completing a use case bug Bugs bugs bugs! core-team-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Skip config substitution if key is "password" great-expectations/great_expectations
2 participants
@eugmandel @anthonyburdi