Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean output of a json from class MicrosoftTeamsRenderer() #3426

Closed
derek-hk opened this issue Sep 21, 2021 · 4 comments · Fixed by #3728
Closed

Boolean output of a json from class MicrosoftTeamsRenderer() #3426

derek-hk opened this issue Sep 21, 2021 · 4 comments · Fixed by #3728
Labels
community devrel This item is being addressed by the Developer Relations Team

Comments

@derek-hk
Copy link

Describe the bug
The JSON output from MicrosoftTeamsRenderer produces "True" boolean values
image

Which turns the JSON become imparseable

To Reproduce
Steps to reproduce the behavior:

  1. Run the Rule Based Validator and call MicrosoftTeamsRenderer() to render the JSON file
    y = MicrosoftTeamsRenderer().render(<your validation result>)
  2. You will see the "True" value when searching in the JSON file produced

Expected behavior
The value of the "True" should be "true"

Environment (please complete the following information):
Python 3.6
Great Expectations Version: 0.13.33

Suspected root cause
Values of a boolean in a JSON could only be either "true" or "false", instead of "True" or "False, while the query part in the source code is giving the latter
image

@derek-hk derek-hk changed the title Boolean output of a json Boolean output of a json from class MicrosoftTeamsRenderer() Sep 21, 2021
@NathanFarmer NathanFarmer added the devrel This item is being addressed by the Developer Relations Team label Sep 21, 2021
@NathanFarmer
Copy link
Contributor

Hi @derek-hk! Thank you for raising this issue. We will take a look and respond soon. In the meantime, if you would be interested in contributing a bug fix, I would be happy to offer any guidance you need.

@SanthoshS20
Copy link

@NathanFarmer Can I contribute to this?

@NathanFarmer
Copy link
Contributor

@SanthoshS20 Yes of course! Please ping me here if you need any guidance, or once you open a PR and need a code review.

@talagluck
Copy link
Contributor

Hi @SanthoshS20 - I wanted to check, are you still interested in contributing this? Please feel free to reach out if you have any questions.

@talagluck talagluck added help wanted Issues we'd love to see community contributions for. Join #contributors-contributing in our Slack! and removed help wanted Issues we'd love to see community contributions for. Join #contributors-contributing in our Slack! labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community devrel This item is being addressed by the Developer Relations Team
Projects
None yet
5 participants