Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: shorter envelopes #85

Closed
kzantow opened this issue Aug 27, 2022 · 6 comments
Closed

Feature request: shorter envelopes #85

kzantow opened this issue Aug 27, 2022 · 6 comments
Labels
breaking enhancement New feature or request

Comments

@kzantow
Copy link

kzantow commented Aug 27, 2022

Describe the bug
The smallest amount one can adjust the envelopes is not small enough for the needs of some percussive sounds. For example, zooming in all the way like like this:
image
With noise yields an audible volume ramp-up, which is not ideal for things like hi-hats, see the corresponding waveform, approximately 20 milliseconds:
image

What did you try to do

  • Enable a single operator
  • Set to noise
  • Adjust envelope to the smallest attack and decay possible, sustain 0

Expected behavior
There is no volume ramp up -- ideally, the attack phase could be length of 0, and either no decay (no sound) or a very fast < 5ms sound.

Screenshots
(added in description)

Software (please complete the following information):

  • OctaSine version: v0.7.0 (the info button is lower-right btw)
  • DAW: Bitwig 4.3.4
  • OS: Windows 10
@greatest-ape
Copy link
Owner

@kzantow Thanks.

The minimum envelope stage length is currently 10ms, as you indicated. Making it shorter means increasing the risk of appearance of audio artefacts such as clicks, especially when there is an interaction with LFOs.

There might however be a lower value which still enables your use case. I'll try to look into it.

@greatest-ape greatest-ape added enhancement New feature or request breaking labels Aug 27, 2022
@kzantow
Copy link
Author

kzantow commented Aug 27, 2022

Thanks for looking at this! I agree about the possibility of audio artefacts, however when using noise or other high frequency content this generally wouldn't an issue, which is one the main use case for this request.

@greatest-ape
Copy link
Owner

greatest-ape commented Aug 27, 2022

Sure, that's true. I want to keep using the same envelope logic for both noise and sine modes, though.

I tried changing the min length to 3ms. I also implemented a fix for your other issue, so that oneshot LFOs stay at the end value. I've done some testing and it seems to work fine so far.

Would you mind trying out the changes? There are some other unreleased changes since 0.7 too, so your patches will likely have to be adjusted, notably modulation output amount, panning and LFO target selection.

OctaSine-tmp-2022-08-26_3-Windows.zip

OctaSine-tmp-2022-08-26_3-macOS-Intel.zip

OctaSine-tmp-2022-08-26_3-Ubuntu-20_04.zip

@kzantow
Copy link
Author

kzantow commented Aug 27, 2022

I gave this a try -- definitely an improvement for both issues! Able to get a kick drum with a transient like this now:
image
This opens up a lot better sound design for percussive sounds 👍

@greatest-ape
Copy link
Owner

Great!

If you have time, it would be great if you could try it out a bit more and see if you encounter any bugs.

@greatest-ape
Copy link
Owner

I’ve merged the changes, so I’m closing the issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants