-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: shorter envelopes #85
Comments
@kzantow Thanks. The minimum envelope stage length is currently 10ms, as you indicated. Making it shorter means increasing the risk of appearance of audio artefacts such as clicks, especially when there is an interaction with LFOs. There might however be a lower value which still enables your use case. I'll try to look into it. |
Thanks for looking at this! I agree about the possibility of audio artefacts, however when using noise or other high frequency content this generally wouldn't an issue, which is one the main use case for this request. |
Sure, that's true. I want to keep using the same envelope logic for both noise and sine modes, though. I tried changing the min length to 3ms. I also implemented a fix for your other issue, so that oneshot LFOs stay at the end value. I've done some testing and it seems to work fine so far. Would you mind trying out the changes? There are some other unreleased changes since 0.7 too, so your patches will likely have to be adjusted, notably modulation output amount, panning and LFO target selection. OctaSine-tmp-2022-08-26_3-Windows.zip |
Great! If you have time, it would be great if you could try it out a bit more and see if you encounter any bugs. |
I’ve merged the changes, so I’m closing the issue :-) |
Describe the bug
The smallest amount one can adjust the envelopes is not small enough for the needs of some percussive sounds. For example, zooming in all the way like like this:
With noise yields an audible volume ramp-up, which is not ideal for things like hi-hats, see the corresponding waveform, approximately 20 milliseconds:
What did you try to do
Expected behavior
There is no volume ramp up -- ideally, the attack phase could be length of 0, and either no decay (no sound) or a very fast < 5ms sound.
Screenshots
(added in description)
Software (please complete the following information):
The text was updated successfully, but these errors were encountered: