Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking new maintainer #16

Closed
greebowarrior opened this issue Jun 3, 2020 · 11 comments
Closed

Seeking new maintainer #16

greebowarrior opened this issue Jun 3, 2020 · 11 comments

Comments

@greebowarrior
Copy link
Collaborator

Due to the fact I no longer own any Squeezebox hardware, I'm not really able to maintain this project any more, so I'm looking for someone who could take over.

Please let me know if you're interested, and I could see about transferring ownership of the repo

@leematt
Copy link
Collaborator

leematt commented Jun 3, 2020

I have three Squeezebox devices and have been using this plugin for a couple of years, albeit with some changes I made for caching the accessories in Homebridge. I'd been meaning to publish my version and maybe issue a pull request, but hadn't fully worked out some kinks and don't know the Homebridge platform very well.

If no one more capable wants to take over, I could do so. As I am still using Squeezebox devices and sort of maintaining the code for myself, and have been interested in further updates for stability and functionality, I might be able to keep things running for a bit longer. 🙂

@rkrug
Copy link
Contributor

rkrug commented Jun 4, 2020

@leemat: out of curiosity - do you have volume control as well?

@leematt
Copy link
Collaborator

leematt commented Jun 6, 2020

out of curiosity - do you have volume control as well?

Very limited. I am just using the volume characteristic that is already in the plugin, and using a HomeKit app that supports that custom characteristic to add volume levels to scenes. So, I can have a scene set all the players to 30% volume, but can't tell Siri to change the volume beyond that. I want to add full volume support if/when possible.

@rkrug
Copy link
Contributor

rkrug commented Jun 6, 2020

OK. That explains. I was only looking into the Home app. Now I looked into the Home+ app, and there is the volume...

Have you seen https://github.com/Supereg/homebridge-http-speaker ? This could be an option, and supported by the Home app as well.

@leematt
Copy link
Collaborator

leematt commented Oct 19, 2020

Unfortunately I've recently suffered a couple of hardware failures on my Squeezebox devices and am no longer using or maintaining them. I may revisit them at some point, but am currently focused on replacing them.

@rkrug
Copy link
Contributor

rkrug commented Oct 19, 2020

I know absolutely nothing about node and javascript and the whole home bridge plugin is completely foreign to me, but I forked the repo (https://github.com/rkrug/homebridge-squeezebox) and implemented the players as fans, so that I now can control the volume (speed) via Siri or in automations.

So - how should this be taken forward? Suggestions?

@okonet
Copy link

okonet commented Nov 2, 2020

What does everyone thinks of creating an organization for it instead so multiple people could be responsible for maintaining it? I think transferring to another single person account will lead to a similar situation in the long term.

This strategy worked well for me with react-dropzone repo.

Another thing I could setup right after is automatic release process so the contribution are made even more simple and do not require maintainer to do additional work besides code review and merging PRs with semantic versioning in mind.

@rkrug
Copy link
Contributor

rkrug commented Nov 2, 2020

Fine with me.

@okonet
Copy link

okonet commented Nov 2, 2020

So the problem I'm trying to prevent is this: #11 (comment) where I had to publish my fork under a separate package on NPM because the PR was never released.

@rkrug
Copy link
Contributor

rkrug commented Nov 2, 2020

I have done the same with implementing fans instead of lights (volume control from HomeKit) https://github.com/rkrug/homebridge-squeezebox
. Why don't you set up an organisation, and I'll join. Warning: I know nothing about javaScript.

@okonet
Copy link

okonet commented Nov 13, 2020

@greebowarrior what do you think about creating an organization for this plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants