Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule EC66 does not apply to the Python language #4

Closed
dedece35 opened this issue Aug 25, 2023 · 4 comments · Fixed by #9
Closed

Rule EC66 does not apply to the Python language #4

dedece35 opened this issue Aug 25, 2023 · 4 comments · Fixed by #9
Assignees
Labels
🏗️ refactoring refactoring for best practices 🗃️ rule rule improvment or rule development or bug 🔥 in progress 🔥

Comments

@dedece35
Copy link
Member

dedece35 commented Aug 25, 2023

please check the analysis done in closed issue in old repository : green-code-initiative/ecoCode#198
existing rule in SonarQube : quite the same subject => "python:S3457"

TO DISCUSS INSIDE CORE_TEAM : opinion ? I'm ok with analysis (Python expert)

@dedece35
Copy link
Member Author

dedece35 commented Oct 6, 2023

after discussion with core-team :

  • "python:S3457" is not the same subject
  • @jhertout will see it and we will come back here with idea
  • if no idea, next @dedece35 will check deeply the given analysis

@jhertout
Copy link

jhertout commented Oct 9, 2023

Hello, I perform some investigation and I confirm the analysis done in green-code-initiative/ecoCode#198.
I cannot see differences in the bytecode too and when going through the python documentation they explicitly say that they can be used indifferently.

I think we can remove this rule for Python. It is not an "instinctive rule" for Python and the documentation and first impression are likely to show that there are no differences.
For me, if this rule is true, measures MUST be done because without them, everything seems to indicate there is no differences.

@dedece35
Copy link
Member Author

dedece35 commented Oct 9, 2023

Hi @jhertout,
thank you for analysis.
ok, I will remove this rule for python and I will create a new MD file to reference this kind of work which must be done.
(plop @glalloue )

@dedece35
Copy link
Member Author

deprecation of EC66 rule done in PRs :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ refactoring refactoring for best practices 🗃️ rule rule improvment or rule development or bug 🔥 in progress 🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants