Add: Auto-allow host for SSH connection (#965)

* Add: Auto-allow host for SSH connection

* update python-gvm dep

* Adjust unittests

gvmtools/helper.py

@@ -89,7 +89,7 @@ def __str__(self):
         return "\n".join(row_strings)
 
 
-def yes_or_no(question):
+def yes_or_no(question: str) -> bool:
     """Asks the user to proceed or not in a gvmtools script
 
     Arguments:
@@ -104,7 +104,7 @@ def yes_or_no(question):
         return yes_or_no("Please enter 'y' or 'n'")
 
 
-def error_and_exit(msg):
+def error_and_exit(msg: str) -> None:
     """Prints an error message and quits the gvmtools script
 
     Arguments:
@@ -200,7 +200,7 @@ def authenticate(gmp, username=None, password=None):
         raise e
 
 
-def run_script(path, global_vars):
+def run_script(path, global_vars) -> None:
     """Loads and executes a file as a python script
 
     Arguments:

gvmtools/parser.py

@@ -22,6 +22,7 @@
 import argparse
 import logging
 from pathlib import Path
+from typing import Optional
 
 from gvm import get_version as get_gvm_version
 from gvm.connections import (
@@ -48,7 +49,7 @@
 
 class CliParser:
     def __init__(
-        self, description, logfilename, *, prog=None, ignore_config=False
+        self, description: str, logfilename, *, prog=None, ignore_config=False
     ):
         bootstrap_parser = argparse.ArgumentParser(
             prog=prog,
@@ -211,6 +212,12 @@ def _add_subparsers(self):
         parser_ssh.add_argument(
             "--ssh-password", help="SSH password (default: %(default)r)"
         )
+        parser_ssh.add_argument(
+            "-A",
+            "--auto-accept-host",
+            action="store_true",
+            help="When executed in e.g. CI, auto accept SSH host addition",
+        )
 
         parser_tls = self._subparsers.add_parser(
             "tls", help="Use TLS secured connection to connect to service"
@@ -314,6 +321,7 @@ def create_connection(
     cafile=None,
     ssh_username=None,
     ssh_password=None,
+    auto_accept_host: Optional[bool] = None,
     **kwargs,  # pylint: disable=unused-argument
 ):
     if "socket" in connection_type:
@@ -335,4 +343,5 @@ def create_connection(
         port=port,
         username=ssh_username,
         password=ssh_password,
+        auto_accept_host=auto_accept_host,
     )

tests/ssh_help.3.10.snap

@@ -1,6 +1,6 @@
 usage: gvm-test-cli ssh [-h] [--hostname HOSTNAME] [--port PORT]
                         [--ssh-username SSH_USERNAME]
-                        [--ssh-password SSH_PASSWORD]
+                        [--ssh-password SSH_PASSWORD] [-A]
 
 options:
   -h, --help            show this help message and exit
@@ -10,3 +10,6 @@ options:
                         SSH username (default: 'gmp')
   --ssh-password SSH_PASSWORD
                         SSH password (default: 'gmp')
+  -A, --auto-accept-host
+                        When executed in e.g. CI, auto accept SSH host
+                        addition

tests/ssh_help.snap

@@ -1,6 +1,6 @@
 usage: gvm-test-cli ssh [-h] [--hostname HOSTNAME] [--port PORT]
                         [--ssh-username SSH_USERNAME]
-                        [--ssh-password SSH_PASSWORD]
+                        [--ssh-password SSH_PASSWORD] [-A]
 
 optional arguments:
   -h, --help            show this help message and exit
@@ -10,3 +10,6 @@ optional arguments:
                         SSH username (default: 'gmp')
   --ssh-password SSH_PASSWORD
                         SSH password (default: 'gmp')
+  -A, --auto-accept-host
+                        When executed in e.g. CI, auto accept SSH host
+                        addition