Use sigtimedwait() instead of waitpid(). #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroosec
force-pushed
the
plugins-timeout
branch
from
a98b7e9
to
9228da0
Compare
Fixes an issue with stuck scans where only a single plugin is running and is beyond its timeout. Blocking indefinitely with waitpid() prevents update_running_processes() from being called to cleanup finished plugins and from checking timeouts.
kroosec
force-pushed
the
plugins-timeout
branch
from
9228da0
to
3656306
Compare
ArnoStiefvater
approved these changes
Mar 21, 2019
jjnicola
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with stuck scans where only a single plugin is running
and is beyond its timeout. Blocking indefinitely with waitpid() prevents
update_running_processes() from being called to cleanup finished plugins
and from checking timeouts.