Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test alive hosts only #456

Merged
merged 63 commits into from Mar 13, 2020
Merged

Test alive hosts only #456

merged 63 commits into from Mar 13, 2020

Conversation

ArnoStiefvater
Copy link
Member

@ArnoStiefvater ArnoStiefvater commented Feb 27, 2020 •
edited

When the scanner preference test_alive_hosts_only is set to yes only alive hosts are tested by the scanner. This feature is still work in progress, hanging scans or unexpected behavior may occur.

Depends on:

You have to change the scanner plugin ping_host.nasl to not run a second alive detection scan. Add the following to the beginning (before or after the function definitions) of ping_host.nasl.

test_alive_hosts_only = get_preference("test_alive_hosts_only");
if(test_alive_hosts_only) {
  exit(0);
}

How fast the alive scanner sends out pings can be specified by the BURSTand BURST_TIMEOUT macros in alivedetection.h.

@ArnoStiefvater
initial commit
72026e7
@ArnoStiefvater
filter by port
0eaea0a 
Instead of filtering for every host individually we filter by port.
This way we can filter for many hosts without running in memory issues
with too big filter descriptions. A new hashtable of the target hosts
is used for not including alive hosts we do not want to scan by mistake.
@ArnoStiefvater
make functions static
0c22b11
@ArnoStiefvater
add barebones icmp
6eb7872 
Add icmp ping capability. Is commented out for now because no mechanism
for multiple metods exist for now.
@ArnoStiefvater
use hashtables and add icmp function
36e25eb 
Use hachtables instead of gvm_hosts_t struct.
Add function for icmp pings.
@ArnoStiefvater
move tcp syn in a GHFunc
9f41168 
Function for tcp syn which is to be used by g_hash_table_foreach().
@ArnoStiefvater
delete function which got replaced
3eb2dbd
@ArnoStiefvater
use thread instead of fork
c439975
@ArnoStiefvater
clang-format
d9b6abc
@ArnoStiefvater
use only one kb_t
fe1d17b 
Do not initialize main_kb every time we want to use it.
@ArnoStiefvater
add ipv6 version functions
a260438
@ArnoStiefvater
add ipv6 tcp syn ping
1782ebd
@ArnoStiefvater
add ipv6 for got_packet() and get icmpv6 in working state
c0619b3 
Packet sniffer can handle IPv4 and IPv6 packets now.
ICMPv6 was simplified and is working as expected now.
@ArnoStiefvater
add simpler version of ICMP
fc85911 
Simplify icmp (ipv4). Kernel builds ipv4 header for us now.
@ArnoStiefvater
add socket for tcpv6
ed6f624 
Temp addition of socket. Will be changed in the future.
@ArnoStiefvater
delete old icmp function
d1899a5
@ArnoStiefvater
make names consisten
35e8ba7
@ArnoStiefvater
close sockets
19f916e
@ArnoStiefvater
delete unused struct and change function locations
abc9815
@ArnoStiefvater
add mechanism for alive detection method selection
a1b8af2 
Ospd puts alive_detection flag in redis. Openvas stores it in a
hashtable we can access.
@ArnoStiefvater
add openvas conf setting for activation of test_alive_hosts_only func…
bfe2efc 
…tionality
@ArnoStiefvater
immprove handling of icmp pings
4439df3
@ArnoStiefvater
streamline tcp_ping and add tcp_ack ping
70754c0
@ArnoStiefvater
add explicit struct for icmp_ping sockets
36c7ed5
@ArnoStiefvater
get alive_test method from ospd
a4acdc1 
On ospd side it is checked if openvas conf 'test_alive_hosts_only' is set
to 'yes'. If it is set, put the ALIVE_TEST enum in redis which is read by
openvas on startup and available via hashtable lookup by prefs_get().
@ArnoStiefvater
add arp ping
4af3795 
Add basic arp ping functionlity.
@ArnoStiefvater
make sniffer thread aware of arp reply
cc10f6b
@ArnoStiefvater
add arp via icmpv6
547d533
@ArnoStiefvater
refactor 1
2b983c6 
One function for getting sockets.
Scanner structure with everything needed for scanning.
Hosts data strukture which holds the hashtables.
Only one sniffer thread instead of starting and stopping.
Clean init and free function.
@ArnoStiefvater
refactor 2
659b03e 
Only init source addresses once and reuse them.
Improve checksum function.
@ArnoStiefvater
improve log messages in sniffer_thread()
557d01b
@ArnoStiefvater
improve code quality
ca55596 
Better error handling and error messages.
Use memset, memcpy etc. instead of deprecated functions.
@ArnoStiefvater
improve error handling
aa8c860
@ArnoStiefvater
add alive_test combinations
b2f3bff
@ArnoStiefvater
pthread does not set errno
6af2f68
@ArnoStiefvater
pthread does not return errno
3adb75c
@ArnoStiefvater
seperate pushing und popping from alive_detection queue
84bfbbc 
Use different redis connection for pushing and popping.
When alive_detection crashed we wound get segfault or error.
@ArnoStiefvater
add different error return values for easy debugging
b4c6279
@ArnoStiefvater
set non-blocking mode on
29b7768 
Somehow pcpa_breakloop seems to work only if this option is set.
@ArnoStiefvater
add wait_for_replies_timeout
1483026 
Timeout for how long to wait for replies after last packet was sent.
@ArnoStiefvater
make functions static
51f45cb 
Make private functions static and add or remove __attribte__ ((unused))
where needed.
@ArnoStiefvater
access alive_detection_tid via functions
f13682b
@ArnoStiefvater
add documentation
65d7d57
@ArnoStiefvater
delete timeout from header
d9f2587
@ArnoStiefvater
use function to access alive_detection_tid
4d4b9df
@ArnoStiefvater
use find_package and CMAKE_THREAD_LIBS_INIT instead of -lpthread
f3adbed
@ArnoStiefvater
set SO_BROADCAST socket option
9158658 
This way we can ping broadcast addresses and do not get permission denied error while pinging.
@ArnoStiefvater
rename file
d010642
@ArnoStiefvater
add changelog entry
cec5692
This was referenced Feb 27, 2020
Merged
Merged
jjnicola
jjnicola previously approved these changes Mar 13, 2020
View reviewed changes
@jjnicola jjnicola self-requested a review March 13, 2020 11:17
@jjnicola jjnicola merged commit c95fbb8 into greenbone:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnicola jjnicola jjnicola approved these changes

@bjoernricks bjoernricks Awaiting requested review from bjoernricks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArnoStiefvater @jjnicola