Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init nvticache init. #459

Merged
merged 1 commit into from Mar 6, 2020
Merged

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Mar 5, 2020

Add a new function to initialize the nvticache without loading the plugins.

Add a new function to initialize the nvticache without loading the plugins.
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it looks straight forward. Personally I would like to know the background of this PR :-)

@jjnicola
Copy link
Member Author

jjnicola commented Mar 6, 2020

Code wise it looks straight forward. Personally I would like to know the background of this PR :-)

With PR #458 I avoid to load plugins when a scan starts, since the plugins load up must be done calling openvas with --update-nvt-feed option. During this plugins load at the init of openvas, it was also done the nvticache init, necessary for the scan.

With this PR, I split the function and now I openvas can init the nvticache when a new start scan, but without loading up the plugins.

@jjnicola jjnicola merged commit 3a635e9 into greenbone:master Mar 6, 2020
@jjnicola jjnicola deleted the dont-init-plugins branch March 6, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants