Add aligned summary to log at scan end #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
vscanner-summary
branch
from
92012ba
to
ce99122
Compare
ArnoStiefvater
requested changes
May 6, 2020
janowagner
force-pushed
the
vscanner-summary
branch
from
ce99122
to
7b55ecf
Compare
For the dead hosts count, extend send_dead_hosts_to_ospd_openvas() to return the number of dead hosts. In function scan() collect the dead hosts count, the scan id and start and end time and send all information to the log at the end of the scan.
This adds the scan id and the number of hosts to the log summary. Use the same scheme as for the alive scanner.
This helps for the case with 0 alive hosts.
janowagner
force-pushed
the
vscanner-summary
branch
from
36e9221
to
e1c0eca
Compare
ArnoStiefvater
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a summary about duration and number of alive and total hosts to the log when the scan finishes. Have one for each, the alive scanner and the vulnerability scanner.
Also add the scan id to allow to distinguish when there are many concurrent scans.