Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates to the nasl_perror() error texts: #542

Merged
merged 1 commit into from Jul 6, 2020
Merged

Various updates to the nasl_perror() error texts: #542

merged 1 commit into from Jul 6, 2020

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Jul 6, 2020

Not that much to say about these changes. The nasl_perror calls were quite inconsistent, this should fix both files.

@cfi-gb cfi-gb requested a review from a team July 6, 2020 11:17
jjnicola
jjnicola previously approved these changes Jul 6, 2020
View reviewed changes
@jjnicola jjnicola dismissed their stale review July 6, 2020 11:51

Check_format fails.

@jjnicola jjnicola self-requested a review July 6, 2020 11:51
jjnicola
jjnicola reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@jjnicola jjnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check format test is failing. Could you adjust the format? you can see the expected format in the check_format test output

@cfi-gb
Various updates to the nasl_perror() error texts:
7f59211 
- Don't use a mix up spaces / no spaces and / or ! and no !
  in the text.
- Add missing newlines.
- Fix IPv6 related function names referring IPv4 function
  names.
@cfi-gb cfi-gb requested a review from jjnicola July 6, 2020 12:31
jjnicola
jjnicola approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jjnicola jjnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jjnicola jjnicola merged commit 633eba1 into greenbone:openvas-20.08 Jul 6, 2020
@cfi-gb cfi-gb deleted the nasl_perror_updates branch July 6, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnicola jjnicola jjnicola approved these changes

@ArnoStiefvater ArnoStiefvater Awaiting requested review from ArnoStiefvater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cfi-gb @jjnicola