Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork vhosts before creating the socket. #576

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

jjnicola
Copy link
Member

This solves the issue in which a parent process creates a socket
and child processes inheritates the socket but are not allow to use it.
Now, each child uses its own socket.

@jjnicola jjnicola requested a review from cfi-gb August 13, 2020 12:17
@jjnicola jjnicola marked this pull request as ready for review August 14, 2020 06:44
@jjnicola jjnicola added the feedback required Additional information is required label Aug 14, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@jjnicola jjnicola removed the feedback required Additional information is required label Aug 14, 2020
This solves the issue in which a parent process creates a socket
and child processes inheritates the socket but are not allow to use it.
Now, each child uses its own socket.
Copy link
Member

@cfi-gb cfi-gb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes scanning SSL/TLS services for me.

Unfortunately i cannot judge on the C-Code changes (e.g. if hostname needs to be freed as well), this needs to be reviewed and approved by a @greenbone/gvm-dev member.

@jjnicola
Copy link
Member Author

I can confirm that this fixes scanning SSL/TLS service for me.

Unfortunately i cannot judge on the C-Code changes (e.g. if hostname needs to be freed as well), this needs to be reviewed and approved by a @greenbone/gvm-dev member.

Thanks a lot for testing @cfi-gb

@ArnoStiefvater ArnoStiefvater merged commit e82d7fc into greenbone:openvas-20.08 Aug 14, 2020
@cfi-gb
Copy link
Member

cfi-gb commented Aug 17, 2020

Backport to the openvas-7.0 branch which is also affected in #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants