Only send the signal if the pid is a positive value. #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfi-gb
suggested changes
Aug 28, 2020
jjnicola
force-pushed
the
kill-pid-systemwide
branch
from
5935cf2
to
afe41de
Compare
ArnoStiefvater
previously approved these changes
Aug 31, 2020
Since kb_item_get_int() will return -1 if the key does not exist. killing with -1 pid will send the signal system wide. Apparently the stop signal is received twice, being the second one sent by a child process, but received after the kb was already cleaned up. Therefore -1 is received and the kill SIGUSR1 signal reaches other process.
jjnicola
force-pushed
the
kill-pid-systemwide
branch
from
afe41de
to
b46c592
Compare
ArnoStiefvater
approved these changes
Aug 31, 2020
cfi-gb
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Only send the signal if the pid is a positive value.
Why:
Since kb_item_get_int() will return -1 if the key does
not exist. killing with -1 as pid will send the signal system wide.
Apparently the stop signal is received twice, being the second one
sent by a child process, but received after the kb was already cleaned up.
Therefore -1 is received and the kill SIGUSR1 signal reaches other process.
How:
You can test this starting 2 or 3 parallel scans with many hosts. This produces a big amount child process which during stops scans, spread the kill signal to other process. You should be able to stop the scans without problem if this patch is applied.
Checklist: