End the scanner in a better way if the host list is malformed. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send a message to the client in case of invalid target list
bjoernricks
reviewed
Nov 20, 2020
2 tasks
ArnoStiefvater
requested changes
Nov 23, 2020
src/attack.c
Outdated
| unresolved = gvm_hosts_resolve (hosts); | ||
| if (hosts == NULL) | ||
| { | ||
| sprintf (buf, "Invalid target list: %s.", hostlist); |
There was a problem hiding this comment.
Buffer is very small (only 96 bytes) and hostlist can get very big. Use snprinf or g_snprintf() and a bigger buffer if its likely that hostlist will exceed 96 bytes length. You can use strlen to get the needed lenght and check it agains the buffer size.
Do we even limit the lenght of a hoststring?
src/attack.c
Outdated
| { | ||
| sprintf (buf, "Invalid target list: %s.", hostlist); | ||
| connect_main_kb (&main_kb); | ||
| message_to_client (main_kb, buf, NULL, NULL, "ERRMSG"); |
There was a problem hiding this comment.
message_to_client has internal buffer with len 2048. Make sure that no buffer overflow can happen in this function too.
ArnoStiefvater
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
End the scanner in a better way if the host list is malformed and send a message to the client in case of invalid target list
Why:
If the target host list is not empty but malformed, the hosts struct is NULL. Then gvm_hosts_resolve() segfaults
How:
Start a scan with gvm-cli (gsa already checks for malformed target) wiht 192.168.0.1/32 as host target.
Checklist: