Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New redis config #668

Merged
merged 7 commits into from
Feb 24, 2021
Merged

New redis config #668

merged 7 commits into from
Feb 24, 2021

Conversation

tuto193
Copy link

@tuto193 tuto193 commented Feb 24, 2021

What:

redis-openvas.conf has been updated and brought to the newest standards, since some settings were either not present at all, or worded wrongly.
Why:
Update

How:
As stated in the git log history:

  1. While comparing this ridis.conf against redis-openvas.conf Settings which were missing (actually missing and not commented out in the redis-openvas.conf) were first added.
  2. The rewording of some settings (actually just renaming from slave to replica was done.
  3. Check at this step, which of the settings that are active in both differ:
Following settings commented out on the redis.conf 5.0
---------------------
Setting         Value(s)
--------------  ---------------------------------
unixsocket      ['/run/redis-openvas/redis.sock']
unixsocketperm  ['770']
syslog-enabled  ['yes']
maxclients      ['10000']

The follwing settings differ in both config files
Setting    redis.conf                   redis-openvas.conf
---------  ---------------------------  ---------------------------------------
port       ['6379']                     ['0']
daemonize  ['no']                       ['yes']
pidfile    ['/var/run/redis_6379.pid']  ['/run/redis-openvas/redis-server.pid']
databases  ['16']                       ['1025']
  1. Replaced the redis-openvas.conf with the redis.conf text.
  2. Changed/added the settings from 3. so original behavior is not affected.

Checklist:

@tuto193 tuto193 requested a review from a team as a code owner February 24, 2021 08:29
@tuto193 tuto193 mentioned this pull request Feb 24, 2021
2 tasks
@jjnicola jjnicola merged commit 662a20b into greenbone:master Feb 24, 2021
@jjnicola
Copy link
Member

Thanks @tuto193 for updating this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants