Don't use g_error. Use g_warning instead and let the scanner to continue #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nue. Error messages are always fatal, resulting in a call to G_BREAKPOINT() to terminate the application. This function will result in a core dump; don't use it for errors you expect. For more information see: https://developer.gnome.org/glib/stable/glib-Message-Logging.html#g-error
ArnoStiefvater
approved these changes
Apr 27, 2021
This was referenced Apr 27, 2021
Merged
jjnicola
added a commit
that referenced
this pull request
Apr 27, 2021
Don't use g_error. Use g_warning instead and let the scanner to continue (backport #710)
jjnicola
added a commit
that referenced
this pull request
Apr 27, 2021
Don't use g_error. Use g_warning instead and let the scanner to continue (backport #710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Don't use g_error. Use g_warning instead and let the scanner to continue
Why:
Error messages are always fatal, resulting in a call to G_BREAKPOINT() to terminate the application. This function will result in a core dump; don't use it for errors you expect.
For more information see:
https://developer.gnome.org/glib/stable/glib-Message-Logging.html#g-error
How:
During a running scan, run a program which consume the whole free memory. The scanner will not fork() because no memory available.
Checklist: