Add endpoint for scanreport model description #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0urself
approved these changes
Sep 23, 2020
bjoernricks
reviewed
Sep 28, 2020
|
|
||
| def __as_md(self, previous_key, data): | ||
| def append(value): | ||
| return isinstance(value, str) or isinstance(value, int) |
There was a problem hiding this comment.
Could have been
return isinstance(value, (str, int))
bjoernricks
reviewed
Sep 28, 2020
| @@ -34,6 +34,7 @@ pytest-django = "^3.9.0" | |||
| weasyprint = "^51" | |||
| matplotlib = "^3.3.1" | |||
| pandas = "^1.1.2" | |||
| rope = "^0.17.0" | |||
There was a problem hiding this comment.
Is rope a direct dependency now or should it still be a dev dependency?
bjoernricks
reviewed
Sep 28, 2020
| @@ -135,3 +135,163 @@ class Report: | |||
| vulnerability_overview: VulnerabilityOverview | |||
| host_overviews: List[HostOverview] | |||
| results: Results | |||
|
|
|||
|
|
|||
| def descripe(): | |||
There was a problem hiding this comment.
I suppose this is a typo and the function should be named describe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Creates a new endpoints to get a markdown table of scanreport model description.
Why:
To have an easy way to include the data description within a confluence page.
How:
Checklist: