Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smasher Edge Detection #111

Open
2 of 4 tasks
Greenfoot5 opened this issue Feb 8, 2023 · 2 comments
Open
2 of 4 tasks

Smasher Edge Detection #111

Greenfoot5 opened this issue Feb 8, 2023 · 2 comments
Assignees
Labels
enhancement An improvement on an existing feature needs more info The issue requires more info Programming The issue involves a non-trivial amount of programming

Comments

@Greenfoot5
Copy link
Owner

Greenfoot5 commented Feb 8, 2023

Smasher used to not deal any damage to enemies whose centres are outside the range. However, modules are still applied, and they are still included in checking if there are any enemies in range.

There were two potential fixes for this:
Option 1

  • Don’t deal damage to enemies with centres outside the range
  • Don’t activate modules on enemies with centres outside the range
  • Don’t include enemies with centres outside the range when checking if there is an enemy in range

Option 2

  • Add a buffer zone/minimum damage enemies can receive

I began work on Option 1, but haven't finished it properly. As this is part of the transfer, I'm not sure if the to-do list is properly updated (hence needs more info).

@Greenfoot5 Greenfoot5 added enhancement An improvement on an existing feature Programming The issue involves a non-trivial amount of programming needs more info The issue requires more info labels Feb 8, 2023
@Greenfoot5
Copy link
Owner Author

Greenfoot5 commented Oct 3, 2023

Option 2 has been implemented in reduction-rebalance branch

@Greenfoot5 Greenfoot5 self-assigned this Mar 11, 2024
@Greenfoot5
Copy link
Owner Author

My fix didn't work, so instead I'm going to change the range slightly. A 0.8f * range for the check to see if any enemies are close. I'll trial this number and if it doesn't produce satisfactory results I'll have to revisit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement on an existing feature needs more info The issue requires more info Programming The issue involves a non-trivial amount of programming
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant