Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the timeout after successful decryption to improve UX #5

Closed
Greenheart opened this issue Apr 24, 2021 · 1 comment

Comments

@Greenheart
Copy link
Owner

We need to investigate if there are any benefits to waiting 1000 ms before showing the decrypted page. For example, it might help with loading the iframe in the background, improving the perceived performance since it might have loaded in the background instead of being shown as a white page to users.

If we don't get any benetfits from the delay, removing it would improve UX.

By removing the success status message, we could also delete some parts of the decrypt template:

  • success helper
  • some tailwind classes won't be used anymore
  • The unlocked icon won't be used anymore and can be removed
  • If we don't swap between icons, the code toggling .hidden for icons could be removed too.

All in all, this would save about 4 kb from the decrypt template.

@Greenheart Greenheart changed the title Consider removing the timeout after sucessful decryption to improve UX Consider removing the timeout after successful decryption to improve UX Apr 27, 2021
@Greenheart
Copy link
Owner Author

fixed in 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant