Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-5253 Footer Accessibility #87

Closed
planet-4 opened this issue Sep 21, 2020 · 1 comment
Closed

PLANET-5253 Footer Accessibility #87

planet-4 opened this issue Sep 21, 2020 · 1 comment
Assignees
@dpivo
Labels
Dev development tickets Easy Feature Frontend tickets that mostly require js/css knowledge Good First Issue
Milestone
Review and improv...

Comments

@planet-4
Copy link

The footer is generally ok, it just needs some tiny tweaks:

  • The slashes are read out loud as "diagonal", they should be aria-hidden.
  • The copyright text should be wrapped by an element with role=text to be treated as a single text.
  • Same with the Copyright symbol and the NRO text.
Reporter: pcuadrad
Sections: Footer

Potentially affected repositories: planet4-master-theme
@planet-4 planet-4 added A11y Dev development tickets Easy Feature Frontend tickets that mostly require js/css knowledge Good First Issue labels Sep 21, 2020
@dpivo dpivo self-assigned this Oct 22, 2020
@comzeradd
Copy link
Member

Fixed at greenpeace/planet4-master-theme#1219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpivo dpivo

Labels
Dev development tickets Easy Feature Frontend tickets that mostly require js/css knowledge Good First Issue
Projects
None yet
Milestone
Review and improve accessibility of s...
Development

No branches or pull requests
3 participants
@comzeradd @dpivo @planet-4