-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gsap 1.20.5 release use es6 modules which has compatibility issues #267
Comments
Releasing such a major update (including breaking changes) as a patch doesn't make any sense. Pretty reckless behaviour in my opinion. Does GSAP even do semantic versioning? |
It took us some time to identify what broken our repo :) It should be version 1.21.0 since the public API has breaking changes. |
@zouloux according to semver breaking changes may only be introduced in 2.0.0 |
@maxlk indeed. Publishing it as a patch only is a bit dangerous. |
Yes, these kind of changes should not be done in a minor version as they can fully automatic break builds. IMO moving forwards is a good thing en should be encouraged. But doing so without breaking existing setups would be highly appreciated. |
So sorry about that everybody! Very good point. I really thought the ESM stuff would actually help solve a lot of issues people were running into, but you're right - that kind of change should be done with a major version bump. So I reverted things, pushed 1.20.6 via NPM, then did the ESM-based stuff as 2.0.0. Hopefully that helps. Again, please accept my apologies! And to be clear, there's still UMD in 2.0.0 in the /umd/ directory. |
While ES6 modules are supported by all modern browsers, old browsers and old build pipelines doesn't support it.
It's preferred to use umd for compatibility.
The text was updated successfully, but these errors were encountered: