Draggable error on Firefox

[gfelizola]

On Firefox, the return of getBoundingClientRect is a DOMRect. This object has no setter method for width property.

I`m getting errors at this line:
https://github.com/greensock/GreenSock-JS/blob/master/src/uncompressed/utils/Draggable.js#L1534

I resolved changing to: if( r.width===undefined ) at the line before.

[jackdoyle]

I'm a little confused - I'm not seeing any errors in Firefox, and that code doesn't require that the object have a "width" setter - it simply checks to see if r.width is a value and if not, it adds it appropriately. The following lines BOTH evaluate as true if r.width is undefined:

if (!r.width) {...
if (r.width === undefined) {...

Can you show me an example of it generating an error in Firefox? Perhaps a codepen demo?

[gfelizola]

When I use the onDrag callback, Im getting this error on FF: TypeError: setting a property that has only a getter` <- Draggable.js: 1528

And if you have a rect width zero width, this validate as false too.

r.width = 0;
if( ! r.width ) { ... // validate as true and run the conditional code, generating this error

See this pen:
http://codepen.io/gfelizola/pen/GeuvL

I'm using FF 29.0.1 on a Mac OSX 10.9.3

[jackdoyle]

Sorry, I'm still confused :)

I'm on exactly the same system (Mac OSX 10.9.3, Firefox 29.0.1) and the only errors I see on that codepen link are a bunch of complaints that "TypeError: others.indexOf is not a function" which is in your code, not Draggable.

How can I see the error you're talking about?

Oh, and I used !r.width to be more concise and it's fine if it evaluates as true when the width is zero (I was aware of that) - I figured if you're hit-testing something that's reporting as zero-width, it deserves double-checking anyway.

Again, I'd really like to figure out how to see the error you're reporting. Nobody else has reported it and I'm not able to get it so I'm kinda baffled. Any more clues?

[JonDum]

I didn't see any errors in draggable either, jack, just the others.indexOf
error.

I'm also perfectly fine with your use of lazy existence checking; I do it
all the time myself.

On Mon, Jun 2, 2014 at 1:25 PM, jackdoyle notifications@github.com wrote:

Sorry, I'm still confused :)

I'm on exactly the same system (Mac OSX 10.9.3, Firefox 29.0.1) and the
only errors I see on that codepen link are a bunch of complaints that
"TypeError: others.indexOf is not a function" which is in your code, not
Draggable.

How can I see the error you're talking about?

Oh, and I used !r.width to be more concise and it's fine if it evaluates
as true when the width is zero (I was aware of that) - I figured if you're
hit-testing something that's reporting as zero-width, it deserves
double-checking anyway.

Again, I'd really like to figure out how to see the error you're
reporting. Nobody else has reported it and I'm not able to get it so I'm
kinda baffled. Any more clues?

—
Reply to this email directly or view it on GitHub
#43 (comment)
.

[gfelizola]

I don`t know why, but that pen is not updated with the last code version.

See at this new pen:
http://codepen.io/gfelizola/pen/msvzt

But I can only get this error at the onDrag callback.
regardz

[jackdoyle]

I tried that URL...still zero errors for me in Firefox. Can you be very specific about what I need to do to generate that error and precisely where I'd look?