Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Usage with Gradle 4: implementation dependencies et al. #9

Open
rubdos opened this issue Nov 29, 2018 · 5 comments
Open

Usage with Gradle 4: implementation dependencies et al. #9

rubdos opened this issue Nov 29, 2018 · 5 comments

Comments

@rubdos
Copy link
Contributor

rubdos commented Nov 29, 2018

The same issue as with this plugin: since Gradle 4, dependencies specified using compile and testCompile are deprecated, and the successors (implementation and testImplementation) and the like cannot be directly accessed.

But unlike the other AAR plugin, for this one there's a pretty "okay" workaround:

apply plugin: 'com.greensopinion.gradle-android-eclipse'

configurations {
    eclipseConfig.extendsFrom implementation
    eclipseTestConfig.extendsFrom testImplementation
}

eclipse {
  classpath {
    plusConfigurations += [
        configurations.eclipseConfig,
        configurations.eclipseTestConfig,
    ]
    downloadSources = true
  }
}

Seems to do the trick.

@greensopinion
Copy link
Owner

Thanks for the suggested workaround. I've been delaying dealing with this issue. I was considering an upstream contribution to the gradle eclipse plug-in. What do you think?

@rubdos
Copy link
Contributor Author

rubdos commented Nov 29, 2018

upstream contribution to the gradle eclipse plug-in

Does that mean that all the gradle-android-eclipse work would be included over there? I'm not sure whether they would accept that, since the eclipse plugin is not specifically targetted to Android.

@greensopinion
Copy link
Owner

I'm not sure. I haven't looked into it deeply enough to know if this issue is an Android-specific thing, or if it's a change in common practices used with Gradle. I agree, if it's Android-specific it doesn't really make sense to try to contribute upstream.

@schildbach
Copy link

For now I think the two plugins should stay separated. One problem of inclusion into the gradle eclipse plug-in would be that releases would be tied to Gradle.

@greensopinion
Copy link
Owner

Potentially some work to be done here, see https://github.com/greensopinion/gradle-android-eclipse/wiki/2020-experiment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants