Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new socket throws when using webpack-dev-middleware instead of dev-server #33

Closed
swernerx opened this issue Mar 19, 2019 · 3 comments
Closed

The new socket throws when using webpack-dev-middleware instead of dev-server #33

swernerx opened this issue Mar 19, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@swernerx
Copy link
Contributor

swernerx commented Mar 19, 2019 •
edited

We are using SSR and build our own server based around webpack-dev-middleware. With the latest update we see a regular issue when loading the page:

http://localhost:3000/sockjs-node/info?t=1553005986947 404 (Not Found)

Unfortunately, the new code breaks for us using our own set-up. Do you mind adding an option to not enable the socket by default?
@gregberge
Copy link
Owner

Hello @swernerx, thanks for your report! Could you submit a PR for it?

@gregberge gregberge added the bug Something isn't working label Mar 19, 2019
@swernerx
Copy link
Contributor Author

Here we go, @neoziro #34

@gregberge
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swernerx @gregberge