-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack magic comments not supported? #8
Comments
Yes of course, I plan to support that as soon as possible. Concerning the two rendering server-side : first we walk threw the React tree (it is less consumer than a rendering), then we render. So there is no two renderings even if it looks like. Can you give me precision about what is broken using webpack magic comments? |
@cloud-walker I just tested it and it does not seem to be a problem using magic comment. Can you please give me more details? |
It was just a quick try! I will do a more focused and clean experiment, so if something will go wrong I will publish it to you :) |
OK thanks! |
First of all, thanks for your effort on this topic!
I've rapidly tried your solution on my project, and seems to work fine, here my observations (with a console.log on the loadable component render):
The fact that you render only one time on the client side its awesome (would be perfect one time on the server side too), but I'd like to use magic comments, any plan on this?
The text was updated successfully, but these errors were encountered: