Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parcel Plugin #235

Merged
merged 7 commits into from Nov 24, 2018
Merged

Conversation

realplatanopapi
Copy link

Summary

I recently published a Parcel plugin for SVGR to npm, and was asked to make it a part of this repo instead. So here we are.

Test plan

I tested the plugin locally in a project I'm working on, and I added some tests.

@vercel
Copy link

vercel bot commented Nov 18, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #235 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   85.43%   85.26%   -0.17%     
==========================================
  Files          29       30       +1     
  Lines         453      448       -5     
  Branches      127      125       -2     
==========================================
- Hits          387      382       -5     
  Misses         55       55              
  Partials       11       11
Impacted Files Coverage Δ
packages/parcel-plugin-svgr/src/asset.js 100% <100%> (ø)
packages/parcel-plugin-svgr/src/index.js 100% <100%> (ø)
packages/rollup/src/index.js 100% <100%> (ø) ⬆️
packages/webpack/src/index.js 94.73% <100%> (-0.92%) ⬇️
babel.config.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3009cb...d58879d. Read the comment docs.

@gregberge
Copy link
Owner

@restlessbit it looks great! I will merge it tomorrow!

@realplatanopapi
Copy link
Author

realplatanopapi commented Nov 19, 2018

@neoziro Awesome! Let me know if you need me to make any changes ✨

@gregberge gregberge merged commit 144dbe3 into gregberge:master Nov 24, 2018
@gregberge
Copy link
Owner

Thanks for your work @restlessbit 🎉

@realplatanopapi realplatanopapi deleted the add.parcel.plugin branch November 24, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants