Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong example in README #56

Closed
chulanovskyi opened this issue Mar 1, 2018 · 5 comments
Closed

Wrong example in README #56

chulanovskyi opened this issue Mar 1, 2018 · 5 comments

Comments

@chulanovskyi
Copy link

In the 'Recipes' section where 'Transform a whole directory' there is an example:

$ svgr -d icons icons

but this doesn't work. First argument should be parent directory. In my case, suppose that I want to parse icons from current directory and put the result to newIcons folder, this command works:

$ svgr ./ -d ./newIcons/

@gregberge
Copy link
Owner

The command works but it is not very clear yes. Thanks for reporting it!

@webberwang
Copy link

glad I came across this, the docs was giving me issues as well

@wuweiweiwu
Copy link
Contributor

@chulanovskyi I agree the example is confusing.

but I think this is what the original command does

$ svgr -d icons icons
         ^^^^     ^^^ 
    dest=icons    src=icons

@gregberge
Copy link
Owner

@wuweiweiwu you are right! Can someone submit a PR to make it less confusing?

@wuweiweiwu
Copy link
Contributor

wuweiweiwu commented Mar 5, 2018

@neoziro Done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants