Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svgo version in plugin-svgo #812

Closed
wants to merge 1 commit into from

Conversation

ruchernchong
Copy link

@ruchernchong ruchernchong commented Jan 1, 2023

Remove deprecated library since native sort is now the recommended by MDN

Summary

Fixes the following warning:

warning @svgr/webpack > @svgr/plugin-svgo > svgo > stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

Fix

Test plan

npm install
npm run build
npm run test

All tests have passed and snapshots were also updated.

Remove deprecated library since native sort is now the recommended by MDN
@vercel
Copy link

vercel bot commented Jan 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svgr ✅ Ready (Inspect) Visit Preview Jan 1, 2023 at 1:24PM (UTC)

@gregberge
Copy link
Owner

@ruchernchong SVGR supports Node.js v10+, supporting Node.js 14+ is a breaking change. I will merge it when I will release a new major.

@ruchernchong
Copy link
Author

@ruchernchong SVGR supports Node.js v10+, supporting Node.js 14+ is a breaking change. I will merge it when I will release a new major.

Understood! Thanks for the quick response to this PR!

@Zamiell
Copy link

Zamiell commented Feb 3, 2023

Are there any rough timelines for a new major version release? I'm also interested in seeing this PR merged.

@ruchernchong
Copy link
Author

ruchernchong commented Feb 7, 2023

@ruchernchong SVGR supports Node.js v10+, supporting Node.js 14+ is a breaking change. I will merge it when I will release a new major.

Is it time that we look to drop support for Node v10 as well? The foundation has already started to even put Node v14 in maintenance and expect to end support soon.

https://github.com/nodejs/Release

@icazemier
Copy link

🙏🏻

@gregberge
Copy link
Owner

Done in another PR.

@gregberge gregberge closed this Mar 24, 2023
@ruchernchong
Copy link
Author

Done in another PR.

Okay, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants