Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove size utility #183

Merged
merged 1 commit into from
Jan 31, 2021
Merged

fix: remove size utility #183

merged 1 commit into from
Jan 31, 2021

Conversation

gregberge
Copy link
Collaborator

@gregberge gregberge commented Jan 30, 2021

Fix #177

Yes, it is a breaking change, but since v2 has not yet been widely adopted, I think it is possible to remove it. I assume it can break some code but the risk is not so big. It was a mistake adding size in v2.

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #183 (3f0ba64) into master (f980ddb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   90.94%   90.93%   -0.01%     
==========================================
  Files          56       56              
  Lines        1005     1004       -1     
  Branches      185      185              
==========================================
- Hits          914      913       -1     
  Misses         90       90              
  Partials        1        1              
Impacted Files Coverage Δ
packages/system/src/styles/sizing.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f980ddb...3f0ba64. Read the comment docs.

@gregberge gregberge merged commit 3fb9239 into master Jan 31, 2021
@gregberge gregberge deleted the remove-size-utility branch January 31, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

size prop overlaps with the <select> element size attribute
1 participant