Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize color modes #185

Merged
merged 1 commit into from
Feb 3, 2021
Merged

perf: optimize color modes #185

merged 1 commit into from
Feb 3, 2021

Conversation

gregberge
Copy link
Collaborator

@gregberge gregberge commented Feb 1, 2021

ColorModeProvider converts all colors into variables, it is not useful, only specified colors in modes are needed.

@gregberge gregberge force-pushed the optimize-color-modes branch 3 times, most recently from b9b1745 to 695677e Compare February 2, 2021 20:49
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #185 (7771b8a) into main (074f36f) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   90.92%   91.04%   +0.11%     
==========================================
  Files          56       56              
  Lines        1003     1016      +13     
  Branches      186      187       +1     
==========================================
+ Hits          912      925      +13     
  Misses         90       90              
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/colorModes.tsx 90.78% <100.00%> (+0.57%) ⬆️
packages/core/src/customProperties.ts 100.00% <100.00%> (ø)
packages/styled-components/src/colorModes.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074f36f...7771b8a. Read the comment docs.

@gregberge gregberge merged commit 7429182 into main Feb 3, 2021
@gregberge gregberge deleted the optimize-color-modes branch February 3, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant