Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

column-gap / row-gap not using theme.space values #200

Closed
P1X3L opened this issue Mar 10, 2021 · 2 comments 路 Fixed by #209
Closed

column-gap / row-gap not using theme.space values #200

P1X3L opened this issue Mar 10, 2021 · 2 comments 路 Fixed by #209
Labels
bug 馃悰

Comments

@P1X3L
Copy link

P1X3L commented Mar 10, 2021

馃悰 Bug Report

When I try to use column-gap or row-gap css properties with values coming from theme.space keys, it does not work.

It works correctly when I use these properties as style props though.

To Reproduce

https://codesandbox.io/s/xstyled-v2-playground-forked-column-gap-row-gap-issue-9ridf

Expected behavior

I expect column-gap and row-gap to be able to get values from theme.space when used in styled-components.
@gregberge
Copy link
Collaborator

Hello @P1X3L, I will add it as soon as I have a moment.

gregberge added a commit that referenced this issue Mar 19, 2021
@gregberge
fix(styled): use space in column-gap & row-gap
6ed1528 
Fix #200
@gregberge gregberge mentioned this issue Mar 19, 2021
Merged
gregberge added a commit that referenced this issue Mar 20, 2021
@gregberge
fix(styled): use space in column-gap & row-gap
517c08e 
Fix #200
@P1X3L
Copy link
Author

P1X3L commented Mar 20, 2021

Thanks @gregberge 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 馃悰
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(styled): use space in column-gap & row-gap styled-components/xstyled
2 participants
@gregberge @P1X3L