Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border-radius handling is buggy #28

Closed
P1X3L opened this issue Jun 19, 2019 · 0 comments
Closed

border-radius handling is buggy #28

P1X3L opened this issue Jun 19, 2019 · 0 comments

Comments

@P1X3L
Copy link

P1X3L commented Jun 19, 2019

πŸ› Bug Report

Using more than one theme value in the border-radius shorthand property is not supported
Using border-top-right-radius, border---radius does'nt allow theme values or integers without units

To Reproduce

βœ… border-radius: 10 compiles to border-radius: 10px
βœ… border-radius: md compiles to border-radius: 10px (if theme.radii.md = 10)
βœ… border-radius: 5px 10px 2px 0px compiles to border-radius: 5px 10px 2px 0px
☠️ border-radius: md sm compiles to border-radius: md sm
☠️ border-radius: 10 5 compiles to border-radius: 10 5
☠️ border-top-right-radius: md compiles to border-top-right-radius: md
☠️ border-top-right-radius: 10 compiles to border-top-right-radius: 10

Expected behavior

border-radius: md sm should compile to border-radius: 10px 5px
border-radius: 10 5 should compile to border-radius: 10px 5px
border-radius: 0.5 0.8 should compile to border-radius: 50% 80%
border-top-right-radius: md should compile to border-top-right-radius: 10px
border-top-right-radius: 10 should compile to border-top-right-radius: 10px
etc...

Link to repl or repo (highly encouraged)

https://github.com/WTTJ/welcome-ui/blob/master/src/components/RadioTab/styles.js#L56

Issues without a reproduction link are likely to stall.

Run npx envinfo --system --binaries --npmPackages @xstyled/system,@xstyled/styled-components,styled-components --markdown --clipboard

Paste the results here:

## System:
 - OS: Linux 4.18 Ubuntu 18.04.2 LTS (Bionic Beaver)
 - CPU: (4) x64 Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
 - Memory: 12.66 GB / 15.48 GB
 - Container: Yes
 - Shell: 3.0.2 - /usr/bin/fish
## Binaries:
 - Node: 10.15.1 - ~/.asdf/installs/nodejs/10.15.1/bin/node
 - Yarn: 1.13.0 - ~/.asdf/installs/nodejs/10.15.1/.npm/bin/yarn
 - npm: 6.4.1 - ~/.asdf/installs/nodejs/10.15.1/bin/npm
@P1X3L P1X3L changed the title border-radius handling unfinished border-radius handling buggy Jun 19, 2019
@P1X3L P1X3L changed the title border-radius handling buggy border-radius handling is buggy Jun 19, 2019
@gregberge gregberge mentioned this issue Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants