Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FlexboxesProps to include FlexBasisProps #332

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix FlexboxesProps to include FlexBasisProps #332

merged 1 commit into from
Dec 16, 2021

Conversation

strozw
Copy link
Contributor

@strozw strozw commented Dec 15, 2021 •
edited

Summary

I want to use flexBasis for the same purpose as flexShrink in typescript.
But currently flexBasis is not available in typescript.

Test plan

before

code completion is not work

スクリーンショット 2021-12-15 9 24 40

after

code completion is work

スクリーンショット 2021-12-15 9 22 44

@strozw strozw marked this pull request as ready for review December 15, 2021 00:25
@strozw strozw changed the title fixe FlexboxesProps to include FlexBasisProps fix FlexboxesProps to include FlexBasisProps Dec 15, 2021
@agriffis agriffis merged commit dbc531b into styled-components:main Dec 16, 2021
@agriffis
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strozw @agriffis