Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get it to work in create react app in Codesandbox #4

Closed
wcastand opened this issue May 28, 2019 · 7 comments 路 Fixed by #5
Closed

Can't get it to work in create react app in Codesandbox #4

wcastand opened this issue May 28, 2019 · 7 comments 路 Fixed by #5

Comments

@wcastand
Copy link

馃悰 Bug Report

I can't get it to work in code sandbox:
code

Expected behavior

It should not output a type error.

Link to repl or repo (highly encouraged)

code

Error i get

TypeError
Cannot set property css of #<Object> which has only a getter
@AlxGolubev
Copy link

It works locally without any issues

@gregberge
Copy link
Collaborator

@wcastand I am working on it!

gregberge added a commit that referenced this issue May 28, 2019
gregberge added a commit that referenced this issue May 28, 2019
Fix the usage in CommonJS world (also on CodeSandbox)

Closes #4
@gregberge
Copy link
Collaborator

@wcastand
Copy link
Author

Awesome, i'll play with it tonight :)
Quick question, right now any variable is accepted. If i do background-color: yellow; it works.
You think it would be possible to have a strict mode where we only accept value from the system, to enforce the "theme" and design system?

@gregberge
Copy link
Collaborator

I don't want to ensure that, flexibility is the key! See #6 for discussion.

@wcastand
Copy link
Author

That's why i'm not saying it should be the default but a possibility.
For me a design system is something to ensure that all your app is coherent. You can't really make sure of that if you can put any value anytime.

If i can't force a design system to specific value then i don't really see any value to a design system. I know it's my point of view and it's really "extreme".

Anyway, that project looks very cool.

@CompuIves
Copy link

CompuIves commented May 28, 2019

Interesting, thanks for fixing it @neoziro! I'll look into what caused the error in CodeSandbox. I'm wondering if it could be related to us resolving main instead of modules from package.json by default 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants