Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fontStyle in typography style props #91

Closed
P1X3L opened this issue Feb 4, 2020 · 1 comment
Closed

Support fontStyle in typography style props #91

P1X3L opened this issue Feb 4, 2020 · 1 comment
Labels
feature request 馃檹

Comments

@P1X3L
Copy link

P1X3L commented Feb 4, 2020

馃殌 Feature Proposal

Add support for the fontStyle style prop.

Motivation

I need this to close an issue in the design system I work on.

Example

<Box fontStyle="italic" />
@P1X3L P1X3L mentioned this issue Feb 4, 2020
Closed
@gregberge
Copy link
Collaborator

You should use style={{ fontStyle: '' }} it has better performances if you don't need responsive.

Could you submit a PR to add it to supported properties? This file is the key: https://github.com/smooth-code/xstyled/blob/master/packages/system/src/styles/typography.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request 馃檹
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregberge @P1X3L