Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move away from mjs extension to work in more environments #275

Merged
merged 1 commit into from Jun 18, 2021

Conversation

AhmedAymanM
Copy link
Contributor

Summary

moved away from using .mjs files extension for es-modules as it seems that there are some compatibility issues with It

Test plan

This code doesn't change any functionality, I ran the tests, and they all pass.

@netlify
Copy link

netlify bot commented Jun 6, 2021

👷 Deploy request for xstyled pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: 613e80a

@snaer-yolabs
Copy link

Nice work man! Hoping this goes out soon

@snaer-yolabs
Copy link

This should fix this issue
#264

@AhmedAymanM
Copy link
Contributor Author

did you test it locally? @snaer-yolabs
I tested it with storybook and it fixed the issue for me.
I didn't try it with next.js or other tools though but I believe it should work nonetheless.

@snaer-yolabs
Copy link

No I did not test it locally @AhmedAymanM

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #275 (613e80a) into main (4865316) will not change coverage.
The diff coverage is n/a.

❗ Current head 613e80a differs from pull request most recent head add2b2a. Consider uploading reports for the commit add2b2a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          60       60           
  Lines        1252     1252           
  Branches      244      244           
=======================================
  Hits         1161     1161           
  Misses         91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4865316...add2b2a. Read the comment docs.

@electroheadfx
Copy link

I have the same error under ViteJS/React install : http://host.electroheadfx.fr/efxbox/laurent/Capturedecran2021-06-19a18.34.32.png I have not any issue with styled-components, chakra-ui (so styled-system) packages with VITE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants