Review and preparation of migration to github.com/ovh #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yadutaf
commented
Mar 16, 2016
yadutaf
commented
- minor styling issues from review
- rename to github.com/ovh/go-ovh/ovh
- test coverage
yadutaf
force-pushed
the
jt-merge-yadutaf-go-ovh
branch
from
ac79a55
to
ea8a162
Compare
yadutaf
force-pushed
the
jt-merge-yadutaf-go-ovh
branch
from
ea8a162
to
7a2c34c
Compare
yadutaf
force-pushed
the
jt-merge-yadutaf-go-ovh
branch
2 times, most recently
from
b6685d6
to
4cce712
Compare
added 2 commits
March 22, 2016 16:18
Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
yadutaf
force-pushed
the
jt-merge-yadutaf-go-ovh
branch
from
4cce712
to
ad133cd
Compare
yadutaf
force-pushed
the
jt-merge-yadutaf-go-ovh
branch
from
ad133cd
to
5b0befe
Compare
added 3 commits
March 22, 2016 16:28
Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
|
Internal reviews have been taken into account, coverage has been improved and the project has been fully renamed to prepare for the migration to OVH's Github. As far as I'm concerned, we are ready to merge. I'll open a separate issue to track this. |
|
Note: test failures are expected as the GOPATH has been migrated |
yadutaf
force-pushed
the
jt-merge-yadutaf-go-ovh
branch
from
5b0befe
to
d68fff5
Compare
Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
|
Note: when using the right command: It does not fail. Interesting... |
gregdel
added a commit
that referenced
this pull request
Mar 22, 2016
Review and preparation of migration to github.com/ovh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.