Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why multiply camera radius by 1.5? #73

Open
trusktr opened this issue May 21, 2017 · 1 comment
Open

Why multiply camera radius by 1.5? #73

trusktr opened this issue May 21, 2017 · 1 comment

Comments

@trusktr
Copy link
Contributor

trusktr commented May 21, 2017

Why do you multiply the camera radius by 1.5?

cameraMatrix = m4.translate(cameraMatrix, 0, 0, radius * 1.5);

Instead of making the radius 200, you could just make it 300. So do we need the 1.5?

@greggman
Copy link
Member

greggman commented May 22, 2017

The radius defines the radius of the circle of Fs. We want the camera to be outside that circle not on that circle.

camera-radius

Yes, you could just make it 300. As it is though it will always be outside the circle of Fs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants